support fname signature verifications #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CassOnMars
force-pushed
the
fname-verification
branch
from
8eb258f to
6579151
Compare
| let proof = fname_transfer.proof.as_ref().unwrap(); | ||
| // TODO: Verify the EIP-712 server signature | ||
|
|
||
| match fname_transfer.verify_signature() { |
There was a problem hiding this comment.
We should also do the same thing here https://github.com/farcasterxyz/snapchain-v0/blob/f5f1aff56fc11f9fb8421e6eeab9277628e35998/src/storage/store/engine.rs#L853-L855 for username proof claim signatures (I just looked and looks like we never call verifyUserNameProofClaim in hubs, this might be a bug?) and the eth verified addresses.
Could you also implement sol verified addresses (maybe in a separate PR? upto you) before moving on to the other validations?
| )); | ||
| } | ||
|
|
||
| let json = json!({ |
There was a problem hiding this comment.
We should make this a const inside validations.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.