-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support fname signature verifications #173
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -444,11 +444,17 @@ impl ShardEngine { | |
"Fname transfer has no proof" | ||
); | ||
} | ||
let proof = fname_transfer.proof.as_ref().unwrap(); | ||
// TODO: Verify the EIP-712 server signature | ||
|
||
match fname_transfer.verify_signature() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should also do the same thing here https://github.com/farcasterxyz/snapchain-v0/blob/f5f1aff56fc11f9fb8421e6eeab9277628e35998/src/storage/store/engine.rs#L853-L855 for username proof claim signatures (I just looked and looks like we never call Could you also implement sol verified addresses (maybe in a separate PR? upto you) before moving on to the other validations? |
||
Ok(_) => {} | ||
Err(err) => { | ||
warn!("Error validating fname transfer: {:?}", err); | ||
} | ||
} | ||
|
||
let event = UserDataStore::merge_username_proof( | ||
&self.stores.user_data_store, | ||
proof, | ||
fname_transfer.proof.as_ref().unwrap(), | ||
txn_batch, | ||
); | ||
match event { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this a const inside validations.ts