Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test milestone repository and integrity test #893

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aziemchawdhary-gs
Copy link
Contributor

Add test milestone repository and integrity test

@aziemchawdhary-gs aziemchawdhary-gs requested a review from a team as a code owner November 14, 2024 23:34
Copy link

github-actions bot commented Nov 14, 2024

Test Results

   379 files     379 suites   1h 15m 21s ⏱️
3 612 tests 3 589 ✔️ 23 💤 0
5 185 runs  5 162 ✔️ 23 💤 0

Results for commit de10a20.

♻️ This comment has been updated with latest results.

@@ -0,0 +1,36 @@
// Copyright 2021 Goldman Sachs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2021 Goldman Sachs
// Copyright 2024 Goldman Sachs

Comment on lines +15 to +24
Class <<temporal.businesstemporal>> meta::test::milestoning::A
{
a : String[1];
}

Class <<temporal.processingtemporal>> meta::test::milestoning::B
{
b : String[1];
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Class <<temporal.businesstemporal>> meta::test::milestoning::A
{
a : String[1];
}
Class <<temporal.processingtemporal>> meta::test::milestoning::B
{
b : String[1];
}
Class <<temporal.businesstemporal>> meta::test::milestoning::A
{
a : String[1];
}
Class <<temporal.processingtemporal>> meta::test::milestoning::B
{
b : String[1];
}

Class <<temporal.businesstemporal>> meta::test::milestoning::FirmAccount extends meta::test::milestoning::Account
{
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also have a bitemporal class and a non-milestoned class, and connections between each type. Also, properties from associations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants