generated from finos/software-project-blueprint
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test milestone repository and integrity test #893
Open
aziemchawdhary-gs
wants to merge
8
commits into
finos:master
Choose a base branch
from
aziemchawdhary-gs:milestoning_test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e4ff0bb
Add milestoning repository test
aziemchawdhary-gs 1434980
Fix checkstyle
aziemchawdhary-gs bf84593
Add more tests
aziemchawdhary-gs a909d4a
undo rogue deletion
aziemchawdhary-gs 101061f
add integrity test
aziemchawdhary-gs 8244aea
fix import
aziemchawdhary-gs 8dd65df
remove duplicate code
aziemchawdhary-gs de10a20
Exclude new repo from pct test builder
aziemchawdhary-gs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
...core/src/test/java/org/finos/legend/pure/m3/TestMilestoningCompileStateIntegrityTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Copyright 2024 Goldman Sachs | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
|
||
package org.finos.legend.pure.m3; | ||
|
||
import org.finos.legend.pure.m3.tests.AbstractCompiledStateIntegrityTest; | ||
import org.junit.BeforeClass; | ||
|
||
public class TestMilestoningCompileStateIntegrityTest extends AbstractCompiledStateIntegrityTest | ||
{ | ||
@BeforeClass | ||
public static void initialize() | ||
{ | ||
initialize("test_milestoning_repository"); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
.../serialization/filesystem/genericrepository/config/TestMilestoningRepositoryProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// Copyright 2024 Goldman Sachs | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package org.finos.legend.pure.m3.serialization.filesystem.genericrepository.config; | ||
|
||
import org.finos.legend.pure.m3.serialization.filesystem.repository.CodeRepository; | ||
import org.finos.legend.pure.m3.serialization.filesystem.repository.CodeRepositoryProvider; | ||
import org.finos.legend.pure.m3.serialization.filesystem.repository.GenericCodeRepository; | ||
|
||
public class TestMilestoningRepositoryProvider implements CodeRepositoryProvider | ||
{ | ||
|
||
@Override | ||
public CodeRepository repository() | ||
{ | ||
return GenericCodeRepository.build("testMilestoningRepository.definition.json"); | ||
} | ||
} |
3 changes: 2 additions & 1 deletion
3
...vices/org.finos.legend.pure.m3.serialization.filesystem.repository.CodeRepositoryProvider
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
org.finos.legend.pure.m3.serialization.filesystem.genericrepository.config.TestGenericRepositoryProvider | ||
org.finos.legend.pure.m3.serialization.filesystem.genericrepository.config.TestOtherGenericRepositoryProvider | ||
org.finos.legend.pure.m3.serialization.filesystem.genericrepository.config.TestOtherGenericRepositoryProvider | ||
org.finos.legend.pure.m3.serialization.filesystem.genericrepository.config.TestMilestoningRepositoryProvider |
5 changes: 5 additions & 0 deletions
5
...ure-core/legend-pure-m3-core/src/test/resources/testMilestoningRepository.definition.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"name" : "test_milestoning_repository", | ||
"pattern" : "(meta)(::.*)?", | ||
"dependencies" : ["platform"] | ||
} |
36 changes: 36 additions & 0 deletions
36
...ore/legend-pure-m3-core/src/test/resources/testMilestoningRepository/testMilestoning.pure
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,36 @@ | ||||||||||||||||||||||||||||||||||||||||
// Copyright 2021 Goldman Sachs | ||||||||||||||||||||||||||||||||||||||||
// | ||||||||||||||||||||||||||||||||||||||||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||||||||||||||||||||||||||||||||
// you may not use this file except in compliance with the License. | ||||||||||||||||||||||||||||||||||||||||
// You may obtain a copy of the License at | ||||||||||||||||||||||||||||||||||||||||
// | ||||||||||||||||||||||||||||||||||||||||
// http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||||||||||||||||||||||||||||||||
// | ||||||||||||||||||||||||||||||||||||||||
// Unless required by applicable law or agreed to in writing, software | ||||||||||||||||||||||||||||||||||||||||
// distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||||||||||||||||||||||||||||||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||||||||||||||||||||||||||||||||
// See the License for the specific language governing permissions and | ||||||||||||||||||||||||||||||||||||||||
// limitations under the License. | ||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||
Class <<temporal.businesstemporal>> meta::test::milestoning::A | ||||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||||
a : String[1]; | ||||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||
Class <<temporal.processingtemporal>> meta::test::milestoning::B | ||||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||||
b : String[1]; | ||||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||
Comment on lines
+15
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||||||||||||||||||
Class <<temporal.businesstemporal>> meta::test::milestoning::Account | ||||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||
Class <<temporal.businesstemporal>> meta::test::milestoning::FirmAccount extends meta::test::milestoning::Account | ||||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should also have a bitemporal class and a non-milestoned class, and connections between each type. Also, properties from associations. |
||||||||||||||||||||||||||||||||||||||||
function meta::test::testSubClassOfBusinessTemporal():Any[*] | ||||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||||
let res = ^meta::test::milestoning::FirmAccount(businessDate=%2021); | ||||||||||||||||||||||||||||||||||||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.