Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade grpc to 1.57.0 #11706

Closed
wants to merge 19 commits into from
Closed

upgrade grpc to 1.57.0 #11706

wants to merge 19 commits into from

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Aug 21, 2023

No description provided.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ncooke3
Copy link
Member

ncooke3 commented Aug 21, 2023

LGTM on green. We can grab the binary artifacts from the resulting nightlies, and update tomorrow.

@ncooke3 ncooke3 requested a review from paulb777 August 21, 2023 14:42
@paulb777
Copy link
Member

Looks like something about the new Boring SSL doesn't work in CocoaPods.

@wu-hui
Copy link
Contributor Author

wu-hui commented Aug 21, 2023

Looks like something about the new Boring SSL doesn't work in CocoaPods.

Yep..checking with grpc

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.11% (acfd28c) to 88.21% (2de342d) by +0.10%.

    FilenameBase (acfd28c)Merge (2de342d)Diff
    exception.cc23.68%84.21%+60.53%
    filesystem_posix.cc79.09%81.82%+2.73%
    leveldb_key.cc98.82%98.14%-0.69%
    leveldb_remote_document_cache.cc94.83%96.55%+1.72%
    task.cc93.91%96.52%+2.61%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/diBu7KXAfL.html

@ncooke3 ncooke3 mentioned this pull request Sep 8, 2023
@paulb777
Copy link
Member

Closing since we've now updated to 1.62.*

@paulb777 paulb777 closed this Mar 23, 2024
@paulb777 paulb777 deleted the wuandy/GRPC157 branch March 23, 2024 00:19
@firebase firebase locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants