[Firestore] Consolidate Firestore and FirestoreSwift (Post-Rollback) #11954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple API Diff ReportCommit: d15ad50 [BUILD ERROR] FirebaseFirestoreSwift |
Coverage Report 1Affected Products
Test Logs |
paulb777
reviewed
Oct 19, 2023
FirebaseFirestoreInternal/FirebaseFirestore/FIRAggregateField.h
Outdated
Show resolved
Hide resolved
andrewheard
approved these changes
Oct 19, 2023
|
CI seems to have stalled but package-HEAD was green, so I will try merging, re-tagging, and staging. |
ncooke3
added a commit
that referenced
this pull request
Oct 19, 2023
This was referenced Oct 19, 2023
ncooke3
added a commit
that referenced
this pull request
Oct 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In this revised approach, I created a
FirebaseFirestoreInternal.podspecthat contains the ObjC/C++/ObjC++ contents of Firestore. Then, theFirebaseFirestore.podspecis now responsible for containing the Swift Firestore API and the re-exporting the public Objective-C API fromFirebaseFirestoreInternal. Last, theFirebaseFirestoreInternalre-exports API that used to live within it. It also throws a warning.