Factor the riesz map out into a separate object. #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dham
commented
Jul 4, 2024
dham
commented
Jul 10, 2024
| o.dat.data[:] = c.dat.data[:] | ||
| else: | ||
| solve, rhs, soln = self._solver | ||
| rhs.assign(value) |
There was a problem hiding this comment.
check whether we need to explicitly zero BCs here.
There was a problem hiding this comment.
Aparently we need to do that, #3498
nbouziani
approved these changes
Jul 10, 2024
Comment on lines
+48
to
+52
| def arguments(self): | ||
| return (self,) | ||
|
|
||
| def coefficients(self): | ||
| return () |
There was a problem hiding this comment.
These two methods are part of the BaseForm interface. I suspect this is needed because it conveniently allows the use of arguments as if they were base forms in a few places in pyadjoint. I think this suggests that, in the long term, the right thing to do is probably to have ufl.Argument as BaseForm. It mathematically makes sense as arguments map V -> V, i.e. V x V* - > R.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description