Remove slurm integration #1233
Merged
Remove slurm integration #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
A) Looking over the code carefully and determining that it hasn't been tested since the Python 2.7 days and that it
B) Doesn't work with the modern codebase
C) Is undocumented
D) In the last released version of Caiman had dependencies on andrea's home directory hardcoded
E) Even if it were fully fixed would almost never provide a performance benefit given current levels of parallelism
F) And is really ugly/weird
this diff removes the old slurm integration from the code.
To be clear: some of our users run Caiman under slurm. This removal does not impact them because nobody we could find was using the slurm integration (given how broken it was and specific to our local cluster, it's unclear how they might've gotten it working). They were just allocating a node under slurm and running caiman on it, which is the same as running any other software on a node. Caiman doesn't notice SLURM by default and doesn't mind its specifics.