Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caimanmanager detect editable #1357

Merged
merged 4 commits into from
May 31, 2024
Merged

caimanmanager detect editable #1357

merged 4 commits into from
May 31, 2024

Conversation

pgunn
Copy link
Member

@pgunn pgunn commented May 31, 2024

This has caimanmanager try to detect (through some fragile code that's in a try/except) when it's running on an install in editable mode and automatically apply the "inplace" modifier to the install subcommand so the user doesn't need to remember to do that.

This lifts two restrictions on the editable mode install:

  1. The need to add --inplace to caimanmanager install
  2. The need (for inplace only) to be in the source directory (when the opposite is required for a pip install without -e)

Will merge this as soon as it passes CI as I'm preparing an urgent release to deal with upstream tensorflow breaking us

@pgunn pgunn mentioned this pull request May 31, 2024
@pgunn pgunn merged commit 2c890ca into dev May 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant