Fix conversion from sparse matrix to dense array when nb == 0 and not low_rank_background #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumping @pgunn, related to a CI error in mesmerize (and this is a bug that people might run into). I realize this mostly became a change to test_toydata, which I hope was an improvement, but I'm definitely open to doing that differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a spot in the code where a sparse matrix was being passed into
np.array, which is not allowed and throws an error. This block of code seems to execute when low_rank_background is False and nb is not set to 0.Partially addresses #1185, nel-lab/mesmerize-core#231.
Type of change
Please delete options that are not relevant.
Has your PR been tested?
I made some changes to test_toydata.py so that it can more easily test multiple different sets of parameters, and then I added a couple of sets for batch processing. I confirmed that without this fix, the one called 'patch-not-lowrank' reproduces this error, and with it the tests pass.