Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

out_kinesis_streams: add custom port support for Kinesis output plugin #9317

Merged
merged 2 commits into from
Nov 9, 2024
Merged

out_kinesis_streams: add custom port support for Kinesis output plugin #9317

merged 2 commits into from
Nov 9, 2024
+138 −3

Commits on Sep 2, 2024

  1. out_kinesis_streams: add custom port support for Kinesis output plugin 

    This patch adds the ability to set a custom port for the Kinesis Streams
output plugin. It introduces a new configuration option 'Port' that allows
users to specify a non-standard port when connecting to the Kinesis service.

The implementation includes:
- Using the port number set in the output instance's host structure
- Falling back to the default HTTPS port (443) if no port is specified
- Validating the port number to ensure it's within the valid range (1-65535)
- Adding appropriate debug and error logging

This feature is useful for scenarios involving proxies or custom network
configurations. It has been tested with various port configurations,
including the default, custom ports, and invalid inputs.

Signed-off-by: Mikhail [azalio] Petrov <[email protected]>
    @azalio
    azalio committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d383b47 View commit details
    Browse the repository at this point in the history

  2. tests: add port configuration tests for kinesis_streams output plugin 

    This commit introduces three new test cases for the kinesis_streams output plugin:

1. flb_test_kinesis_default_port: Verifies that the plugin works correctly
   with the default port configuration.

2. flb_test_kinesis_custom_port: Ensures that the plugin can be configured
   to use a custom port (8443 in this case) and still function properly.

3. flb_test_kinesis_invalid_port: Checks that the plugin fails to start
   when an invalid port number (99999) is specified.

These tests enhance the coverage of the kinesis_streams plugin by validating
its behavior with different port configurations, including error handling
for invalid inputs.

Signed-off-by: Mikhail [azalio] Petrov <[email protected]>
    @azalio
    azalio committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    682776d View commit details
    Browse the repository at this point in the history