out_kinesis_streams: add custom port support for Kinesis output plugin #9317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing
Documentation
|
|
@cosmo0920 Please, could you do a review. |
cosmo0920
requested changes
Sep 2, 2024
This patch adds the ability to set a custom port for the Kinesis Streams output plugin. It introduces a new configuration option 'Port' that allows users to specify a non-standard port when connecting to the Kinesis service. The implementation includes: - Using the port number set in the output instance's host structure - Falling back to the default HTTPS port (443) if no port is specified - Validating the port number to ensure it's within the valid range (1-65535) - Adding appropriate debug and error logging This feature is useful for scenarios involving proxies or custom network configurations. It has been tested with various port configurations, including the default, custom ports, and invalid inputs. Signed-off-by: Mikhail [azalio] Petrov <[email protected]>
This commit introduces three new test cases for the kinesis_streams output plugin: 1. flb_test_kinesis_default_port: Verifies that the plugin works correctly with the default port configuration. 2. flb_test_kinesis_custom_port: Ensures that the plugin can be configured to use a custom port (8443 in this case) and still function properly. 3. flb_test_kinesis_invalid_port: Checks that the plugin fails to start when an invalid port number (99999) is specified. These tests enhance the coverage of the kinesis_streams plugin by validating its behavior with different port configurations, including error handling for invalid inputs. Signed-off-by: Mikhail [azalio] Petrov <[email protected]>
azalio
force-pushed
the
kinesis-custom-port-option
branch
from
82799d3
to
682776d
Compare
azalio
changed the title
|
I kicked off the testing workflows. Waiting for the results. |
As I see it, all the checks have been successfully completed. Could you merge PR? |
cosmo0920
approved these changes
Sep 2, 2024
|
I added |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Kinesis output plugin by adding support for custom port configuration. The changes include:
Added a new configuration option 'port' to allow users to specify a custom port for Kinesis connections.
Modified the plugin initialization to use the custom port when specified, defaulting to the standard port (443) when not provided.
Updated the connection logic to utilize the custom port when establishing connections to Kinesis.
Added error handling to validate the port number, ensuring it's within a valid range (1-65535).
Updated documentation to reflect the new 'port' configuration option.
Added new unit tests to verify the functionality of the custom port feature:
These changes provide users with more flexibility in configuring their Kinesis output, especially in environments where non-standard ports are required.
The implementation maintains backwards compatibility, as the default behavior remains unchanged when no custom port is specified.
Closes #9160