[Inspector V2] Prevent inspector tree scroll from bouncing (#8367)

flutter · Sep 30, 2024 · b4f50fb · b4f50fb
1 parent 89e6c7e
commit b4f50fb
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/packages/devtools_app/lib/src/screens/inspector_v2/inspector_tree_controller.dart b/packages/devtools_app/lib/src/screens/inspector_v2/inspector_tree_controller.dart
@@ -990,9 +990,14 @@ class _InspectorTreeState extends State<InspectorTree>
       safeViewportHeight,
     );
 
+    // Decide to scroll based on whether the middle of the center-left half of
+    // the row is visible. See https://github.com/flutter/devtools/pull/8367.
+    final centerLeftHalf = Offset(
+      (rect.centerLeft.dx + rect.center.dx) / 2,
+      rect.center.dy,
+    );
     final isRectInViewPort =
-        viewPortInScrollControllerSpace.contains(rect.topLeft) &&
-            viewPortInScrollControllerSpace.contains(rect.bottomRight);
+        viewPortInScrollControllerSpace.contains(centerLeftHalf);
     if (isRectInViewPort) {
       // The rect is already in view, don't scroll
       return;