DevtoolsToggleButton and ServiceExtensionButton have same text color
#8377
Conversation
| label: label, | ||
| minScreenWidthForTextBeforeScaling: | ||
| minScreenWidthForTextBeforeScaling, | ||
| child: ImageIconLabel( |
There was a problem hiding this comment.
is this the correct fix here? or is the fix to apply the color properly in material icon label? devtools_app_shared is a public package so we should be careful about making changes here that may potentially break downstream UIs
There was a problem hiding this comment.
Updated MaterialIconLabel instead. This will however change the appearance of the label for any clients who didn't specify a color. Previously if color was null, the Flutter framework would decide on the color for the icon based on the iconTheme, but the text label color wouldn't match because the color there is null.
I think from the code it was intended that the icon and its label would always have the same color. If we want to only fix the DevtoolsToggleButton case I could explicitly pass in the color parameter.
There was a problem hiding this comment.
Can we fix this without making changes to devtools_app_shared?
There was a problem hiding this comment.
Done - I added some optional parameters, but this shouldn't affect any existing widgets from devtools_app_shared
Fixes #8365
Unselected:
Selected:
Before this change: