Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevtoolsToggleButton and ServiceExtensionButton have same text color #8377

Merged
merged 9 commits into from
Oct 2, 2024
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 4 additions & 3 deletions packages/devtools_app_shared/lib/src/ui/buttons.dart
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,10 @@ final class DevToolsToggleButton extends StatelessWidget {

@override
Widget build(BuildContext context) {
final theme = Theme.of(context);
return DevToolsToggleButtonGroup(
borderColor: outlined || isSelected
? Theme.of(context).focusColor
: Colors.transparent,
borderColor:
outlined || isSelected ? theme.focusColor : Colors.transparent,
selectedStates: [isSelected],
onPressed: (_) => onPressed(),
fillColor: fillColor,
Expand All @@ -250,6 +250,7 @@ final class DevToolsToggleButton extends StatelessWidget {
child: Container(
padding: const EdgeInsets.symmetric(horizontal: denseSpacing),
child: MaterialIconLabel(
color: isSelected ? theme.colorScheme.primary : null,
iconData: icon,
label: label,
minScreenWidthForTextBeforeScaling:
Expand Down