-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Structure for updating to the NewPassManager #167
base: main
Are you sure you want to change the base?
Conversation
ef3ac66
to
dce66ae
Compare
src/c/CMakeLists.txt
Outdated
@@ -7,11 +7,15 @@ if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") | |||
# require at least Clang 9.0 | |||
if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0) | |||
message(FATAL_ERROR "Clang++ version must be at least 9.0!") | |||
elseif (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 11) | |||
elseif (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 15) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we double check these version comparisons? Is PERFFLOWASPECT_CLANG_15_NEWER
supposed to be >=clang15 or >clang15?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>=
from what I recall from my testing (returns true of clang 15). I will test again.
…to common.hpp/cpp as opposed to just the current hpp file.
…y the problem, but still debugging
does not include PassManagerBuilder.h header that was removed in clang17
getInt8PtrTy removed in clang18
6ea2647
to
5e50d3a
Compare
WIP.
Fixes #162.
Fixes #176.
perfflow_weave.hpp/cpp
toperfflow_weave_legacy_pass.hpp/cpp
perfflow_weave_new_pass.hpp/cpp
perfflow_weave_common.hpp
into.hpp/.cpp
modifyAnnotatedFunctions()
method, make it easier to read/explainTesting:
-gcc
module-gcc
modulelibstdc++
)Note: Adiak related testing that builds on top of this PR has been moved to a separate branch, see #172.