plugin: move flux_respond () to end of functions
#431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
added
improvement
cmoussa1
changed the title
flux_respond () to end of functionsflux_respond () to end of functions
|
I don't think so. I think this call is supposed to be placed at the end of the callback in the event where there is no error. This commit was actually part of some work on an old (and now closed PR) that was pointed out by @grondo - maybe he could confirm that this is still ok? |
cmoussa1
force-pushed
the
move.flux-respond
branch
from
124a50e to
5c24d21
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
=======================================
Coverage 83.39% 83.39%
=======================================
Files 23 23
Lines 1457 1457
=======================================
Hits 1215 1215
Misses 242 242
|
cmoussa1
force-pushed
the
move.flux-respond
branch
from
5c24d21 to
775b42a
Compare
|
@grondo if you have some time this week or next, could you please give this PR a look? |
Problem: There are a couple callbacks in the plugin that call flux_respond () before they are done processing. Move these calls to just before the functions call "return".
cmoussa1
force-pushed
the
move.flux-respond
branch
from
775b42a to
5583e5a
Compare
|
Thanks!! setting MWP here |
cmoussa1
requested review from
jameshcorbett
and removed request for
jameshcorbett
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a couple callbacks in the plugin that call
flux_respond ()before they are done processing.This PR moves these calls to just before the functions call
return.