Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: move flux_respond () to end of functions #431

Merged
merged 1 commit into from
Aug 28, 2024
Merged

plugin: move flux_respond () to end of functions #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/plugins/mf_priority.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,6 @@ static void rec_update_cb (flux_t *h,
goto error;
}

if (flux_respond (h, msg, NULL) < 0)
flux_log_error (h, "flux_respond");

if (!data || !json_is_array (data)) {
flux_log (h, LOG_ERR, "mf_priority: invalid bulk_update payload");
goto error;
Expand Down Expand Up @@ -312,6 +309,8 @@ static void rec_update_cb (flux_t *h,
users_def_bank[uid] = def_bank;
}

if (flux_respond (h, msg, NULL) < 0)
flux_log_error (h, "flux_respond");
return;
error:
flux_respond_error (h, msg, errno, flux_msg_last_error (msg));
Expand All @@ -337,9 +336,6 @@ static void rec_q_cb (flux_t *h,
goto error;
}

if (flux_respond (h, msg, NULL) < 0)
flux_log_error (h, "flux_respond");

if (!data || !json_is_array (data)) {
flux_log (h, LOG_ERR, "mf_priority: invalid queue info payload");
goto error;
Expand Down Expand Up @@ -370,6 +366,8 @@ static void rec_q_cb (flux_t *h,
q->priority = priority;
}

if (flux_respond (h, msg, NULL) < 0)
flux_log_error (h, "flux_respond");
return;
error:
flux_respond_error (h, msg, errno, flux_msg_last_error (msg));
Expand Down
Loading