bug: context missing from EventsToRegister #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
force-pushed
the
queue-extensions-bug
branch
from
4eac550 to
77424b4
Compare
Problem: the custom scheduler plugin interface now requires a context variable (which is empty/not used) Solution: add context.Context for it. Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
queue-extensions-bug
branch
from
77424b4 to
363f1d8
Compare
Signed-off-by: vsoch <[email protected]>
|
Note that cert-manager is failing in three different projects of mine (this one included) so there was some change, either to it or GitHub. I'm going to try updating first and then try to figure out the error if necessary. |
cmisale
approved these changes
Dec 11, 2024
|
Thank you @cmisale ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the custom scheduler plugin interface now requires a context variable, and return of an array and error (which is empty/not used and nil)
Solution: add context.Context for it, and the correct return signature.
Error: https://github.com/flux-framework/flux-k8s/actions/runs/12217632429/job/34082138214
If there are other errors that resulted from updates (still hiding under this one) I'll follow up with fixes here.