Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reintroduce find subcommand and unify rev spec #62

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

dhnasa
Copy link
Collaborator

@dhnasa dhnasa commented Dec 7, 2023

the last symlink no longer exists, so we need another way to easily get the latest revision in external scripts

all subcommands (except restore) accept multiple revisions

Related issue(s): PL-131963

  • Change is documented in changelog

Security implications

  • Security requirements defined? (WHERE)

    • Principle of Defense in depth -> wrong matches can lead to accidentally removing unexpected/too many tags resulting in revisions being purged which shouldn't be
    • Fail securely -> providing invalid/malformed input will crash the program, parsing happens before actual actions happen
  • Security requirements tested? (EVIDENCE)

    • added unit tests

@dhnasa dhnasa changed the title reintroduce find subcommand reintroduce find subcommand and unify rev spec Dec 8, 2023
doc/man-backy.rst Outdated Show resolved Hide resolved
doc/man-backy.rst Outdated Show resolved Hide resolved
doc/man-backy.rst Show resolved Hide resolved
src/backy/backup.py Show resolved Hide resolved
src/backy/backup.py Outdated Show resolved Hide resolved
@dhnasa dhnasa marked this pull request as draft December 18, 2023 13:34
ctheune
ctheune previously approved these changes Dec 18, 2023
src/backy/tests/test_archive.py Show resolved Hide resolved
src/backy/tests/test_archive.py Outdated Show resolved Hide resolved
src/backy/backup.py Show resolved Hide resolved
src/backy/main.py Show resolved Hide resolved
@dhnasa dhnasa force-pushed the reintroduce-find branch 2 times, most recently from 4d98b86 to 86ccfb0 Compare December 21, 2023 18:38
ctheune
ctheune previously approved these changes Jan 22, 2024
@ctheune
Copy link
Member

ctheune commented Jan 22, 2024

The security considerations are missing. We are processing user input here, are there implications?

Please update the PR template similar to fc-nixos to include the pointers for the security considerations.

Johann Bahl added 2 commits February 1, 2024 22:54
the `last` symlink no longer exists, so we need another way to easily
get the latest revision in external scripts
all subcommands (except restore) accept multiple revisions
@dhnasa dhnasa marked this pull request as ready for review February 1, 2024 22:05
@dhnasa dhnasa mentioned this pull request Feb 5, 2024
3 tasks
@dhnasa dhnasa merged commit cb23df1 into main Feb 28, 2024
3 checks passed
@dhnasa dhnasa deleted the reintroduce-find branch February 28, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants