Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle resource overrides in KF plugins #4467

Merged
merged 15 commits into from
Nov 30, 2023

PR comments

1d29e02
Select commit
Loading
Failed to load commit list.
Merged

Correctly handle resource overrides in KF plugins #4467

PR comments
1d29e02
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 27, 2023 in 1s

32.17% of diff hit (target 60.04%)

View this Pull Request on Codecov

32.17% of diff hit (target 60.04%)

Annotations

Check warning on line 20 in flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go#L16-L20 

Added lines #L16 - L20 were not covered by tests

Check warning on line 27 in flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go#L23-L27 

Added lines #L23 - L27 were not covered by tests

Check warning on line 40 in flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go#L36-L40 

Added lines #L36 - L40 were not covered by tests

Check warning on line 47 in flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go#L43-L47 

Added lines #L43 - L47 were not covered by tests

Check warning on line 59 in flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go#L55-L59 

Added lines #L55 - L59 were not covered by tests

Check warning on line 71 in flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go#L64-L71 

Added lines #L64 - L71 were not covered by tests

Check warning on line 87 in flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go#L75-L87 

Added lines #L75 - L87 were not covered by tests

Check warning on line 103 in flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go#L91-L103 

Added lines #L91 - L103 were not covered by tests

Check warning on line 122 in flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/plugin_exec_context.go#L107-L122 

Added lines #L107 - L122 were not covered by tests

Check warning on line 273 in flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go#L269-L273 

Added lines #L269 - L273 were not covered by tests

Check warning on line 289 in flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go#L275-L289 

Added lines #L275 - L289 were not covered by tests

Check warning on line 314 in flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go#L303-L314 

Added lines #L303 - L314 were not covered by tests

Check warning on line 320 in flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go#L316-L320 

Added lines #L316 - L320 were not covered by tests

Check warning on line 326 in flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go#L323-L326 

Added lines #L323 - L326 were not covered by tests

Check warning on line 340 in flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go#L328-L340 

Added lines #L328 - L340 were not covered by tests

Check warning on line 347 in flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go#L342-L347 

Added lines #L342 - L347 were not covered by tests

Check warning on line 350 in flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/common/common_operator.go#L350 

Added line #L350 was not covered by tests

Check warning on line 73 in flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go#L72-L73 

Added lines #L72 - L73 were not covered by tests

Check warning on line 111 in flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go#L111 

Added line #L111 was not covered by tests

Check warning on line 116 in flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go#L116 

Added line #L116 was not covered by tests

Check warning on line 132 in flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go#L132 

Added line #L132 was not covered by tests

Check warning on line 71 in flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go#L70-L71 

Added lines #L70 - L71 were not covered by tests

Check warning on line 94 in flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go#L94 

Added line #L94 was not covered by tests

Check warning on line 99 in flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go#L99 

Added line #L99 was not covered by tests

Check warning on line 69 in flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow/tensorflow.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow/tensorflow.go#L68-L69 

Added lines #L68 - L69 were not covered by tests
View more details on Codecov