Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle resource overrides in KF plugins #4467

Merged
merged 15 commits into from
Nov 30, 2023

PR comments

1d29e02
Select commit
Loading
Failed to load commit list.
Merged

Correctly handle resource overrides in KF plugins #4467

PR comments
1d29e02
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 27, 2023 in 0s

59.58% (-0.46%) compared to 33b0c6e

View this Pull Request on Codecov

59.58% (-0.46%) compared to 33b0c6e

Details

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (33b0c6e) 60.04% compared to head (1d29e02) 59.58%.

❗ Current head 1d29e02 differs from pull request most recent head 1bb70a6. Consider uploading reports for the commit 1bb70a6 to get more accurate results

Files Patch % Lines
...ks/pluginmachinery/flytek8s/plugin_exec_context.go 0.00% 75 Missing ⚠️
.../plugins/k8s/kfoperators/common/common_operator.go 1.61% 61 Missing ⚠️
...lugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go 72.72% 5 Missing and 4 partials ⚠️
...o/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go 69.56% 4 Missing and 3 partials ⚠️
...s/plugins/k8s/kfoperators/tensorflow/tensorflow.go 88.57% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4467      +/-   ##
==========================================
- Coverage   60.04%   59.58%   -0.46%     
==========================================
  Files         203      632     +429     
  Lines       16187    53612   +37425     
==========================================
+ Hits         9719    31944   +22225     
- Misses       5502    19146   +13644     
- Partials      966     2522    +1556

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov