Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration test config #5058

Merged
merged 9 commits into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flyteadmin/script/integration/k8s/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,9 @@ spec:
- name: flyteadmin
image: flyteadmin:test
imagePullPolicy: IfNotPresent
env:
- name: USE_INTEGRATION_TEST_CONFIG
value: "True"
securityContext:
privileged: true
readinessProbe:
Expand Down
23 changes: 18 additions & 5 deletions flyteadmin/tests/bootstrap.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package tests
import (
"context"
"fmt"
"os"

"gorm.io/gorm"

Expand All @@ -19,9 +20,19 @@ const insertExecutionQueryStr = `INSERT INTO "executions" ` +
`("execution_project","execution_domain","execution_name","phase","launch_plan_id","workflow_id") ` +
`VALUES ('%s', '%s', '%s', '%s', '%d', '%d')`

const integrationTestConfigEnvVar = "USE_INTEGRATION_TEST_CONFIG"

var adminScope = promutils.NewScope("flyteadmin")

func getDbConfig() *database.DbConfig {
if os.Getenv(integrationTestConfigEnvVar) == "True" {
return getIntegrationDbConfig()
} else {
return getSandboxDbConfig()
}
}

func getIntegrationDbConfig() *database.DbConfig {
return &database.DbConfig{
Postgres: database.PostgresConfig{
Host: "postgres",
Expand All @@ -32,13 +43,15 @@ func getDbConfig() *database.DbConfig {
}
}

func getLocalDbConfig() *database.DbConfig {
// Run `flytectl demo start` to start the sandbox
func getSandboxDbConfig() *database.DbConfig {
Comment on lines +46 to +47
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ysysys3074 you can try this config to run integration tests

return &database.DbConfig{
Postgres: database.PostgresConfig{
Host: "localhost",
Port: 5432,
DbName: "flyteadmin",
User: "postgres",
Host: "localhost",
Port: 30001,
DbName: "flyte",
Password: "postgres",
User: "postgres",
},
}
}
Expand Down
Loading