integration test config #5058
Merged
integration test config #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: troychiu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5058 +/- ##
=======================================
Coverage 59.00% 59.00%
=======================================
Files 645 645
Lines 55578 55578
=======================================
Hits 32792 32792
Misses 20194 20194
Partials 2592 2592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Mar 14, 2024
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
Signed-off-by: troychiu <[email protected]>
pingsutw
reviewed
Mar 14, 2024
Comment on lines
+47
to
+48
| // Run `flytectl demo start` to start the sandbox | ||
| func getSandboxDbConfig() *database.DbConfig { |
There was a problem hiding this comment.
cc @ysysys3074 you can try this config to run integration tests
Signed-off-by: troychiu <[email protected]>
dosubot
bot
added
size:M
katrogan
reviewed
Mar 14, 2024
katrogan
previously approved these changes
Mar 15, 2024
Signed-off-by: troychiu <[email protected]>
katrogan
previously approved these changes
Mar 15, 2024
Signed-off-by: troychiu <[email protected]>
|
Catch some places that I didn't modify correspondingly. (don't know why IDE didn't catch that) |
Signed-off-by: troychiu <[email protected]>
dosubot
bot
added
size:S
pingsutw
approved these changes
Mar 15, 2024
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
Signed-off-by: troychiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Local integration test for flyteadmin will fail because of the out-of-dated db config.
What changes were proposed in this pull request?
Set sandbox db as default and add a environment variable in github action.
With these changes, contributors can easily run integration test locally and the github action can keep running