feat: url breadcrumbs feature #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## top-level-masonary-rework #784 +/- ##
============================================================
Coverage ? 66.42%
============================================================
Files ? 509
Lines ? 12440
Branches ? 2337
============================================================
Hits ? 8263
Misses ? 4177
Partials ? 0 |
FrankFlitton
force-pushed
the
url-breadcrumbs-feature
branch
2 times, most recently
from
540b5e3
to
9e78964
Compare
FrankFlitton
force-pushed
the
url-breadcrumbs-feature
branch
from
3cfc811
to
ecda3ec
Compare
ursucarina
requested review from
a team,
ursucarina,
jsonporter and
4nalog
and removed request for
a team
FrankFlitton
force-pushed
the
url-breadcrumbs-feature
branch
from
83d53ee
to
5365045
Compare
FrankFlitton
force-pushed
the
top-level-masonary-rework
branch
from
381d3be
to
cad695b
Compare
FrankFlitton
force-pushed
the
url-breadcrumbs-feature
branch
from
b7eb060
to
67e9e27
Compare
jsonporter
approved these changes
Jul 25, 2023
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
fix: dropdown breadcrumbs Signed-off-by: Soham Parekh <[email protected]> Co-authored-by: Soham Parekh <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
Signed-off-by: Frank Flitton <[email protected]>
FrankFlitton
force-pushed
the
url-breadcrumbs-feature
branch
from
10fe9d2
to
162f36b
Compare
jsonporter
pushed a commit
that referenced
this pull request
Jul 26, 2023
* chore: new nav bar Signed-off-by: Frank Flitton <[email protected]> * feat: url breadcrumbs feature (#784) * chore: new nav bar Signed-off-by: Frank Flitton <[email protected]> * chore: navbar quick links Signed-off-by: Frank Flitton <[email protected]> * chore: task, workflow, launchplans Signed-off-by: Frank Flitton <[email protected]> * chore: remove unused import Signed-off-by: Frank Flitton <[email protected]> * chore: fixup navbar integration Signed-off-by: Frank Flitton <[email protected]> * chore: fix linter Signed-off-by: Frank Flitton <[email protected]> * chore: execution async value Signed-off-by: Frank Flitton <[email protected]> * chore: fix types build fail Signed-off-by: Frank Flitton <[email protected]> * chore: async self link Signed-off-by: Frank Flitton <[email protected]> * chore: add some exports Signed-off-by: Frank Flitton <[email protected]> * chore: change to names export Signed-off-by: Frank Flitton <[email protected]> * chore: spelling Signed-off-by: Carina Ursu <[email protected]> * chore: fix timestamps Signed-off-by: Carina Ursu <[email protected]> * chore: fix file upload type failure Signed-off-by: Frank Flitton <[email protected]> * chore: fix Executions title not updating Signed-off-by: Frank Flitton <[email protected]> * chore: remove depricated types file for dropzone Signed-off-by: Frank Flitton <[email protected]> * chore: fix execution launch plan self link Signed-off-by: Frank Flitton <[email protected]> * chore: pass custom component Signed-off-by: Frank Flitton <[email protected]> * chore: fix named entity cases Signed-off-by: Frank Flitton <[email protected]> * chore: different custom component style Signed-off-by: Frank Flitton <[email protected]> * chore: dynamic breadcrumb hook with event dispatch Signed-off-by: Frank Flitton <[email protected]> * chore: dynamic breadcrumb hook with event dispatch Signed-off-by: Frank Flitton <[email protected]> * chore: project and domains link to dashboard Signed-off-by: Frank Flitton <[email protected]> * chore: add localstorage setting Signed-off-by: Frank Flitton <[email protected]> * chore: get localstorage setting Signed-off-by: Frank Flitton <[email protected]> * chore: named entities self links Signed-off-by: Frank Flitton <[email protected]> * chore: spacing and scaffolding Signed-off-by: Frank Flitton <[email protected]> * chore: grey header color Signed-off-by: Frank Flitton <[email protected]> * fix/dropdown breadcrumbs (#799) fix: dropdown breadcrumbs Signed-off-by: Soham Parekh <[email protected]> Co-authored-by: Soham Parekh <[email protected]> * chore: global inject without emotion Signed-off-by: Frank Flitton <[email protected]> * chore: generate id Signed-off-by: Frank Flitton <[email protected]> * chore: initial unit tests Signed-off-by: Frank Flitton <[email protected]> * chore: fix incorrect localstore value Signed-off-by: Frank Flitton <[email protected]> * chore: named entities execution tests Signed-off-by: Frank Flitton <[email protected]> * chore: domain and project util tests Signed-off-by: Frank Flitton <[email protected]> * chore: fix execution list page title 404 ing Signed-off-by: Frank Flitton <[email protected]> * chore: fix swipe left to go back Signed-off-by: Frank Flitton <[email protected]> * chore: feature flag breadcrumb UI content Signed-off-by: Frank Flitton <[email protected]> * chore: set flags from url Signed-off-by: Frank Flitton <[email protected]> * chore: set flags from exxternal config Signed-off-by: Frank Flitton <[email protected]> * chore: set feature flags from env Signed-off-by: Frank Flitton <[email protected]> * chore: get flags from external env Signed-off-by: Frank Flitton <[email protected]> * chore: better docs from breadcrumbs interface Signed-off-by: Frank Flitton <[email protected]> --------- Signed-off-by: Frank Flitton <[email protected]> Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Soham Parekh <[email protected]> Co-authored-by: Carina Ursu <[email protected]> Co-authored-by: etdotal <[email protected]> Co-authored-by: Soham Parekh <[email protected]> * chore: console version bump Signed-off-by: Frank Flitton <[email protected]> --------- Signed-off-by: Frank Flitton <[email protected]> Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Soham Parekh <[email protected]> Co-authored-by: Carina Ursu <[email protected]> Co-authored-by: etdotal <[email protected]> Co-authored-by: Soham Parekh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Change the page header to be consistent across the app with interactive breadcrumbs.
Type
Are all requirements met?
Complete description
A row of breadcrumbs will appear above the page header. Each one may contain a drop down with links to similar items, eg workflows linking to other workflow pages. Project and domain switching is also supported.
The last item in the list will be treated as a page header.
A breadcrumb list can be provided in the config for custom breadcrumbs.
The approach is to parse the URL for even odd key value pairs. Then, the url segment, as well as complete URL and the next and previous segments, are passed to a validator within each bread crumb object that controls if it should render or not for a given URL. The value the breadcrumb displays is either directly from the URL or evaluated at runtime.
A breadcrumb object must be supplied or no breadcrumb will be rendered for a given URL segment.
Todo: link to design docs.
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA