Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change string length before collapse in json view #844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xwk1246
Copy link
Contributor

@xwk1246 xwk1246 commented Feb 22, 2024

TL;DR

Most S3 storage links are longer than 80 characters and would collapse. Changing the length to 100 will prevent the links from collapsing.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Change the length before collapse to 100.

Follow-up issue

NA

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.17%. Comparing base (a162fb0) to head (86b5d31).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #844   +/-   ##
=======================================
  Coverage   63.17%   63.17%           
=======================================
  Files         528      528           
  Lines       13449    13449           
  Branches     2567     2567           
=======================================
  Hits         8497     8497           
  Misses       4952     4952           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw
Copy link
Member

@jsonporter could we merge this?

before:
image
after:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants