pretix-src should not be a shared volume #10
Conversation
url must include the scheme
|
how does the source get updated if it is a shared volume? it's not mounting out of a users work directory (at least it wasn't as configured). if it had been mounting a users work directory, then we would not have seen the error because the checked out code would have been used instead of an old version. i think that the point here is to test the containers, so the dev containers should be as close as possible to production. to test dev code locally the better change is to replace the image with build. i apply this change locally, which allows me to rebuild the docker image after each code change: |
| @@ -29,8 +29,7 @@ services: | |||
| volumes: | |||
| - ./pretix.cfg:/etc/pretix/pretix.cfg:ro | |||
| - pretix-data:/data | |||
| - pretix-src:/pretix/src | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
If we remove this, we shouldn't need the volume at the end either correct?
There was a problem hiding this comment.
sorry, i missed this question. (for some reason i am not getting notifications on replies to my pull requests)
i don't understand what you are asking though. which volume do we not need?
in any case i am surprised that this is not merged yet. i believe this is a critical fix. without it we always risk testing the wrong code instead of the actual docker container.
|
I will update the whole repo according to what we have in |
this fixes the docker problems we had with the eventyay-tickets PR #76 ( fossasia/eventyay-tickets#76 )
because the src directory was a shared volume, it contained an old version of the code that was mounted on top of the updated code in the container.
we always want the code in the container.
if there is anything in src that needs to be shared, then it will have to be handled separately, ideally by moving it to data.