Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pretix-src should not be a shared volume #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pretix-src should not be a shared volume #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ services:
volumes:
- ./pretix.cfg:/etc/pretix/pretix.cfg:ro
- pretix-data:/data
- pretix-src:/pretix/src


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this, we shouldn't need the volume at the end either correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i missed this question. (for some reason i am not getting notifications on replies to my pull requests)
i don't understand what you are asking though. which volume do we not need?

in any case i am surprised that this is not merged yet. i believe this is a critical fix. without it we always risk testing the wrong code instead of the actual docker container.

db:
image: postgis/postgis:12-2.5-alpine
container_name: pretalx-db
Expand Down
2 changes: 1 addition & 1 deletion pretix.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[pretix]
instance_name=eventyay-tickets
url=localhost
url=http://localhost
currency=USD
; DO NOT change the following value, it has to be set to the location of the
; directory *inside* the docker container
Expand Down