refactor(scrapers.tasks.update_from_text): reuse make_citation in update_from_text

[grossir]

Solves #4903

• Move make_citation from cl_scrape_opinions into scrapers.utils
• Move citation_is_duplicated from cl_back_scrape_citations into scrapers.utils
• Delete scraped_citation_object_is_valid, now we rely on eyecite, used by make_citation
• Refactor test site to account for changes

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: cl/scrapers/tasks.py

Function	Unhandled Issue
update_document_from_text	AttributeError: 'NoneType' object has no attribute 'items' cl.scrapers.tasks.extract_d... Event Count: 122

---

_{Did you find this useful? React with a 👍 or 👎}

[flooie]

Would it make more sense to throw the error logging here - and not pass court id into make citation.

[grossir]

It's awkward to pass the court_id only for logging, but if we didn't do it inside this function we would have to make an outside logger.error call everytime make_citation returns None

[grossir]

I fixed the tests; and added a call to extract_doc_content to update_from_text, for when the text extraction failed. I noticed we weren't covering this use case on the command, and it's actually a very important one.

Please give it another check @flooie

UPDATE: we have already done all the steps needed before merging it:

1. merge the fix(extract_from_text): now returns a plain citation string juriscraper#1298 in Juriscraper
2. publish a new juriscraper
3. update the poetry requirement in this PR to that new Juriscraper version

So that it doesn't break anything
I tested it in my local env with the juriscraper branch, and it's working!

# copy some PA Super cluster where citation extraction had failed; then

docker exec -it cl-django pip uninstall juriscraper
docker exec -it cl-django pip install https://github.com/freelawproject/juriscraper/archive/extract_from_text_citations.zip

docker exec -it cl-django python /opt/courtlistener/manage.py update_from_text --courts juriscraper.opinions.united_states.state.pasuperct --verbosity 3 --date-filed-gte=2024-12-01 --date-filed-lte=2026-01-01 --cluster-status=Published

[flooie]

@grossir this looks great - and will be great to get these errors gone.

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ ValueError: The 'local_path' attribute has no file associated with it. cl.lib.microservice_utils in microservice View Issue

_{Did you find this useful? React with a 👍 or 👎}