fix(extract_from_text): now returns a plain citation string #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves #1297 We will use eyecite on Courtlistener's site to parse and validate the citation string
|
Spent some time thinking if the "Citation" value should be a string or a dict... {
"Citation": {"citation" : "2023 VT 3"}
}or {
"Citation": "2023 VT 3"
}I couldn't really answer, maybe you have an opinion? |
|
is there a corresponding PR in CL to review? |
|
Just up here |
flooie
reviewed
Jan 14, 2025
Comment on lines
116
to
+122
| """ | ||
| metadata = {} | ||
| regex = r"(?P<volume>20\d{2})\s(?P<reporter>ND)\s(?P<page>\d+)" | ||
| regex = r"20\d{2}\sND\s\d+" | ||
| citation_match = re.search(regex, scraped_text[:1000]) | ||
|
|
||
| if citation_match: | ||
| # type 8 is a neutral citation in Courtlistener | ||
| metadata["Citation"] = {**citation_match.groupdict(), "type": 8} | ||
| metadata["Citation"] = citation_match.group(0) |
There was a problem hiding this comment.
Looks like ND doesnt need this anymore.
There was a problem hiding this comment.
I just saw that ND has changed; it will require further changes to clean the case name
Do you mind if I merge this and do the nd changes in a different branch?
flooie
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1297
We will use eyecite on Courtlistener's site to parse and validate the citation string