-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tools test #9
Open
nh13
wants to merge
1
commit into
main
Choose a base branch
from
feature/test_main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
"""Testing utilities for :module:`~pyclient.tools`""" | ||
|
||
import pytest | ||
|
||
|
||
def _to_name(tool) -> str: # type: ignore | ||
"""Gives the tool name for a function by taking the function name and replacing | ||
underscores with hyphens.""" | ||
return tool.__name__.replace("_", "-") | ||
|
||
|
||
def test_tool_funcs(tool, main) -> None: # type: ignore | ||
name = _to_name(tool) | ||
argv = [name, "-h"] | ||
with pytest.raises(SystemExit) as e: | ||
main(argv=argv) | ||
assert e.type == SystemExit | ||
assert e.value.code == 0 # code should be 0 for help |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
"""Tests for :module:`~pyclient.tools.__main__ | ||
Motivation | ||
~~~~~~~~~~ | ||
The idea is to run help on the main tools method (`-h`) as well as on | ||
each tool (ex. `tool-name -h`). This should force :module:`~defopt` | ||
to parse the docstring for the method. Since :module:`~defopt` uses | ||
:module:`~argparse` underneath, `SystemExit`s are raised, which are | ||
different than regular `Exceptions`. The exit code returned by help | ||
(the usage) is 0. An improperly formatted docstring throws a | ||
:class:`NotImplementedException`. We add a few tests below to show | ||
this. | ||
""" | ||
|
||
import pytest | ||
from pyclient.tools.__main__ import TOOLS | ||
from pyclient.tools.__main__ import main | ||
from pyclient.tools.tests import test_tool_funcs as _test_tool_funcs | ||
|
||
|
||
def test_tools_help() -> None: | ||
"""Tests that running pyclient-tools with -h exits OK""" | ||
argv = ["-h"] | ||
with pytest.raises(SystemExit) as e: | ||
main(argv=argv) | ||
assert e.type == SystemExit | ||
assert e.value.code == 0 # code should be 0 for help | ||
|
||
|
||
@pytest.mark.parametrize("tool", TOOLS) | ||
def test_tool_funcs(tool) -> None: # type: ignore | ||
_test_tool_funcs(tool, main) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.