Define github-hostname for trusted teams #1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for scenarios where trusted-teams from multiple github instances have to be considered. Co-authored-by: Tuan Anh Nguyen <[email protected]>
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
/hold do not merge (yet), requires cfg changes |
gardener-robot
added
size/s
gardener-robot-ci-3
added
needs/ok-to-test
ccwienk
requested changes
Nov 4, 2024
| @dataclasses.dataclass(frozen=True) | ||
| class TrustedTeams: | ||
| github_hostname: str | ||
| teams: list[str] |
There was a problem hiding this comment.
list is mutable. declaring the dataclass as frozen is inconsistent w/ that. suggestion: declare the class as mutable (non-frozen)
| '''Pull requests created/synchronized by members of this team will automatically have | ||
| the required label set by the webhook-dispatcher | ||
| ''' | ||
| return self.raw.get('trusted_teams', []) | ||
| return [ | ||
| dacite.from_dict( |
There was a problem hiding this comment.
can we keep this simpler and just keep a list of strings? it should be fairly simple to discriminate between qualified and non-qualified teams, as github does not allow / (or . for that matter) characters in team-names.
Hence, entries of the form foo/bar (two parts if splitting by /) should be safe to translate to <org>/<teamname>, whereas entries of the form host.tld/foo/bar (three parts if splitting by /) should be safe to interpret as qualified
|
merge with #1070 , let's follow-up there |
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for scenarios where trusted-teams from multiple github instances have to be considered.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: