-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider github-hostname when checking trusted_teams
#1070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 4, 2024
depends on: edit: |
gardener-robot
added
needs/review
Needs review
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
labels
Nov 4, 2024
gardener-robot-ci-2
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 4, 2024
general remark: as this pullrequests depends, as you stated yourself, on another pullrequest, against the very same repository, I suggest to merge both changes (using separate commits) into one shared pullrequest |
ccwienk
requested changes
Nov 4, 2024
zkdev
force-pushed
the
zkdev-trusted-teams-check-hostname
branch
from
November 5, 2024 14:23
0c3ccb6
to
3a3194e
Compare
gardener-robot
added
the
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
label
Nov 5, 2024
gardener-robot
removed
the
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
label
Nov 5, 2024
Co-Authored: Tuan Anh Nguyen <[email protected]>
zkdev
force-pushed
the
zkdev-trusted-teams-check-hostname
branch
from
November 5, 2024 14:27
3a3194e
to
912c612
Compare
ccwienk
approved these changes
Nov 5, 2024
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/changes
Needs (more) changes
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/review
Needs review
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: