Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider github-hostname when checking trusted_teams #1070

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

zkdev
Copy link
Member

@zkdev zkdev commented Nov 4, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 4, 2024
@zkdev
Copy link
Member Author

zkdev commented Nov 4, 2024

depends on:
#1069

edit:
invalidated, PRs merged

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 4, 2024
@ccwienk
Copy link
Member

ccwienk commented Nov 4, 2024

general remark: as this pullrequests depends, as you stated yourself, on another pullrequest, against the very same repository, I suggest to merge both changes (using separate commits) into one shared pullrequest

whd/pull_request.py Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 4, 2024
@zkdev zkdev force-pushed the zkdev-trusted-teams-check-hostname branch from 0c3ccb6 to 3a3194e Compare November 5, 2024 14:23
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Nov 5, 2024
@gardener-robot gardener-robot removed the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Nov 5, 2024
@zkdev zkdev merged commit 204b99c into master Nov 6, 2024
11 checks passed
@zkdev zkdev deleted the zkdev-trusted-teams-check-hostname branch November 6, 2024 09:29
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants