v2.0.2

Using `getBoundingClientRect()` instead of jQuery `.position()` when LoadingOverlay is displayed on an element with `position : fixed`
gasparesganga · Mar 20, 2018 · 01539cc · 01539cc
1 parent 4660a66
commit 01539cc
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
 
+## v2.0.2 - 2018-03-20
+### Fixed
+- Using `getBoundingClientRect()` instead of jQuery `.position()` when LoadingOverlay is displayed on an element with `position : fixed`
+
+
+
 ## v2.0.1 - 2018-03-16
 ### Fixed
 - Changed value for overlay `justify-content` CSS property from `space-evenly` to `space-around`: Edge didn't like the former

diff --git a/dist/loadingoverlay.js b/dist/loadingoverlay.js
@@ -1,7 +1,7 @@
 /***************************************************************************************************
 LoadingOverlay - A flexible loading overlay jQuery plugin
     Author          : Gaspare Sganga
-    Version         : 2.0.1
+    Version         : 2.0.2
     License         : MIT
     Documentation   : https://gasparesganga.com/labs/jquery-loading-overlay/
 ***************************************************************************************************/
@@ -374,7 +374,7 @@ LoadingOverlay - A flexible loading overlay jQuery plugin
         // Overlay
         if (!wholePage) {
             var isFixed = container.css("position") === "fixed";
-            var pos     = isFixed ? container.position() : container.offset();            
+            var pos     = isFixed ? container[0].getBoundingClientRect() : container.offset();            
             overlay.css({
                 "position"  : isFixed ? "fixed" : "absolute",
                 "top"       : pos.top + parseInt(container.css("border-top-width"), 10),

diff --git a/dist/loadingoverlay.min.js b/dist/loadingoverlay.min.js
diff --git a/dist/loadingoverlay.min.js.map b/dist/loadingoverlay.min.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "gasparesganga-jquery-loading-overlay",
-    "version": "2.0.1",
+    "version": "2.0.2",
     "description": "A flexible loading overlay jQuery plugin",
     "homepage": "https://gasparesganga.com/labs/jquery-loading-overlay/",
     "author": "Gaspare Sganga <[email protected]> (https://gasparesganga.com)",

diff --git a/src/loadingoverlay.js b/src/loadingoverlay.js
@@ -1,7 +1,7 @@
 /***************************************************************************************************
 LoadingOverlay - A flexible loading overlay jQuery plugin
     Author          : Gaspare Sganga
-    Version         : 2.0.1
+    Version         : 2.0.2
     License         : MIT
     Documentation   : https://gasparesganga.com/labs/jquery-loading-overlay/
 ***************************************************************************************************/
@@ -374,7 +374,7 @@ LoadingOverlay - A flexible loading overlay jQuery plugin
         // Overlay
         if (!wholePage) {
             var isFixed = container.css("position") === "fixed";
-            var pos     = isFixed ? container.position() : container.offset();            
+            var pos     = isFixed ? container[0].getBoundingClientRect() : container.offset();            
             overlay.css({
                 "position"  : isFixed ? "fixed" : "absolute",
                 "top"       : pos.top + parseInt(container.css("border-top-width"), 10),