landing page updated #1

rishabh2609 · 2017-08-14T08:11:03Z

No description provided.

AnshulMalik

Left some comments

AnshulMalik · 2017-08-14T08:20:00Z

landing page/js/main.js

@@ -0,0 +1,49 @@
+


Shouldn't we use two spaces as a tab? Which text editor are you using ?

You should enable translate_tabs_to_spaces here: https://www.sublimetext.com/docs/3/indentation.html

AnshulMalik · 2017-08-14T08:21:32Z

landing page/backup.txt

@@ -0,0 +1 @@
+eyIxIjp7IklEIjoxLCJuYW1lIjoiTXkgaWNvbnMgY29sbGVjdGlvbiIsImJvb2ttYXJrX2lkIjoidjEycjhhOGt3czAwMDAwMCIsImNyZWF0ZWQiOm51bGwsInVwZGF0ZWQiOjE1MDI2OTc2OTAsImFjdGl2ZSI6MSwic291cmNlIjoibG9jYWwiLCJvcmRlciI6MCwiY29sb3IiOiIwMDAwMDAiLCJzdGF0dXMiOjF9LCJ2MTJyOGE4a3dzMDAwMDAwIjpbeyJpZCI6MjU0NDEyLCJ0ZWFtIjowLCJuYW1lIjoieW91dHViZSIsImNvbG9yIjoiIzAwMDAwMCIsInByZW1pdW0iOjAsInNvcnQiOjJ9LHsiaWQiOjYwNTQzLCJ0ZWFtIjowLCJuYW1lIjoiZ21haWwtbG9nbyIsImNvbG9yIjoiIzAwMDAwMCIsInByZW1pdW0iOjAsInNvcnQiOjN9LHsiaWQiOjg4MDAsInRlYW0iOjAsIm5hbWUiOiJ0d2l0dGVyLWxvZ28tc2lsaG91ZXR0ZSIsImNvbG9yIjoiIzAwMDAwMCIsInByZW1pdW0iOjAsInNvcnQiOjR9LHsiaWQiOjMzNzAyLCJ0ZWFtIjowLCJuYW1lIjoiZmFjZWJvb2stbG9nbyIsImNvbG9yIjoiIzAwMDAwMCIsInByZW1pdW0iOjAsInNvcnQiOjF9XX0=


Looks like encrypted data, what's this?

dont know i didn't add this

rewanthtammana · 2017-08-14T09:42:55Z

landing page/js/main.js

+	)
+	;
+	TweenMax.to('#main_info_cont', 1, 
+	{


Follow standard conventions all over your code. Use format similar to call at Line54.

rewanthtammana · 2017-08-14T09:48:00Z

landing page/js/main.js

+		delay: 2.5
+	}
+	)
+	;


This kind of snippet is preferred );.

Replace Line 8 and 9 with );.

Do the same at L16, L42, L49.

rewanthtammana

Please make the following changes.

rewanthtammana

Please make the following changes.

rewanthtammana · 2017-08-14T09:54:32Z

landing page/index.html

+<!DOCTYPE html>
+<html>
+<head>
+	<title>TedX Nit Kurukshetra</title>


Missing meta-tags. Tags like author, links, description, charset, etc are missing.
Check the source-code of techspardha.org for more information.

rewanthtammana

Here are a few tips.

Make sure to double check the changes before committing them here.
Setup your text editor before you start coding. Set the default tab spaces to 2 and then continue coding.

Maintain separate commit messages for each task/review comment. It will be easy for us to review the code based on commit messages.

rewanthtammana · 2017-08-14T10:20:42Z

landing page/css/main.css

@@ -0,0 +1,76 @@
+@font-face {
+	font-family: hLight;


Set the default tab spaces to 2. The code looks clean from L58-76. Follow the same kind of indentation from line from lines 1 to 58.

Follow the same coding convention in all the files.

rewanthtammana · 2017-08-14T10:21:25Z

landing page/index.html

+<!DOCTYPE html>
+<html lang="en">
+<head>
+	<title>TedX Nit Kurukshetra</title>


Fix the indentation in all your files.

AnshulMalik · 2017-08-14T10:52:52Z

landing page/css/main.css

+    footer {
+    	margin-top: 100px !important;	
+    }
+}


Every file must contain a newline character at the end, in short, an empty line at the end.

rewanthtammana

Change TEDx NIT Kurukshetra image to TEDxNITKurukshetra and put this in a single line.

rewanthtammana · 2017-08-19T04:11:57Z

index.html

+	<meta charset="utf-8">
+	<meta name="viewport" content="width=device-width, initial-scale=1">
+	<meta name="description" content="TEDx NIT, Kurukshetra" />
+    <meta name="robots" content="index, follow" />


Indentation not followed from line 8-21. Set the indentation to 4 spaces.

rewanthtammana · 2017-08-19T05:12:01Z

index.html

+    <link rel="author" href="http://gawds.in" />
+    <meta name="author" content="gawds" />
+    <!-- Open Graph data -->
+    <meta property="og:title" content="TEDx NITK" />


Change content to content="TEDxNITKurukshetra"

Make the same changes to Twitter card and Schema.org markup for Google+ sections. It helps SEO to find our website easily.

rewanthtammana · 2017-08-19T05:14:37Z

index.html

+    <!-- Open Graph data -->
+    <meta property="og:title" content="TEDx NITK" />
+    <meta property="og:type" content="website" />
+    <meta property="og:description" content="TEDx NIT, Kurukshetra" />


Change the description content to TEDx NITKurukshetra. Coming soon. <Add extra details.>

Make the same changes to Twitter card and Schema.org markup for Google+ sections.

rewanthtammana · 2017-08-19T07:38:24Z

Fix these errors as well, https://www.codacy.com/app/Gawds/tedxnitkurukshetra-frontend/pullRequest?prid=838804

AnshulMalik · 2017-09-08T02:06:42Z

Please don't push everything here, first resolve the issues/changes asked and create a new PR for other work.

landing page updated

18d175f

AnshulMalik reviewed Aug 14, 2017

View reviewed changes

rishabh2609 added 2 commits August 14, 2017 14:30

backup.txt removed

ec86c20

splash added

da50cd9

rewanthtammana reviewed Aug 14, 2017

View reviewed changes

rewanthtammana requested changes Aug 14, 2017

View reviewed changes

rishabh2609 added 2 commits August 14, 2017 15:36

meta tags added

dd912b0

minor changes for display block

d88c8ab

rewanthtammana requested changes Aug 14, 2017

View reviewed changes

AnshulMalik reviewed Aug 14, 2017

View reviewed changes

rishabh2609 added 5 commits August 18, 2017 20:53

scroll bar change

9ff9537

tab spacing changed

757a960

tedx logo change

b1a2625

links added

55073eb

favicon added

392e521

rewanthtammana requested changes Aug 19, 2017

View reviewed changes

rishabh2609 added 2 commits September 7, 2017 23:27

complete ui change

413e212

particles js added

ea58b79

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

landing page updated #1

landing page updated #1

rishabh2609 commented Aug 14, 2017

AnshulMalik left a comment

AnshulMalik Aug 14, 2017

rishabh2609 Aug 14, 2017

AnshulMalik Aug 14, 2017

AnshulMalik Aug 14, 2017

rishabh2609 Aug 14, 2017

rewanthtammana Aug 14, 2017

rewanthtammana Aug 14, 2017

rewanthtammana left a comment

rewanthtammana left a comment

rewanthtammana Aug 14, 2017

rewanthtammana left a comment

rewanthtammana Aug 14, 2017 •

edited

Loading

rewanthtammana Aug 14, 2017

AnshulMalik Aug 14, 2017

rewanthtammana left a comment

rewanthtammana Aug 19, 2017

rewanthtammana Aug 19, 2017

rewanthtammana Aug 19, 2017

rewanthtammana Aug 19, 2017

rewanthtammana Aug 19, 2017

rewanthtammana commented Aug 19, 2017

AnshulMalik commented Sep 8, 2017 •

edited

Loading

		@@ -0,0 +1 @@
		eyIxIjp7IklEIjoxLCJuYW1lIjoiTXkgaWNvbnMgY29sbGVjdGlvbiIsImJvb2ttYXJrX2lkIjoidjEycjhhOGt3czAwMDAwMCIsImNyZWF0ZWQiOm51bGwsInVwZGF0ZWQiOjE1MDI2OTc2OTAsImFjdGl2ZSI6MSwic291cmNlIjoibG9jYWwiLCJvcmRlciI6MCwiY29sb3IiOiIwMDAwMDAiLCJzdGF0dXMiOjF9LCJ2MTJyOGE4a3dzMDAwMDAwIjpbeyJpZCI6MjU0NDEyLCJ0ZWFtIjowLCJuYW1lIjoieW91dHViZSIsImNvbG9yIjoiIzAwMDAwMCIsInByZW1pdW0iOjAsInNvcnQiOjJ9LHsiaWQiOjYwNTQzLCJ0ZWFtIjowLCJuYW1lIjoiZ21haWwtbG9nbyIsImNvbG9yIjoiIzAwMDAwMCIsInByZW1pdW0iOjAsInNvcnQiOjN9LHsiaWQiOjg4MDAsInRlYW0iOjAsIm5hbWUiOiJ0d2l0dGVyLWxvZ28tc2lsaG91ZXR0ZSIsImNvbG9yIjoiIzAwMDAwMCIsInByZW1pdW0iOjAsInNvcnQiOjR9LHsiaWQiOjMzNzAyLCJ0ZWFtIjowLCJuYW1lIjoiZmFjZWJvb2stbG9nbyIsImNvbG9yIjoiIzAwMDAwMCIsInByZW1pdW0iOjAsInNvcnQiOjF9XX0=

landing page updated #1

Are you sure you want to change the base?

landing page updated #1

Conversation

rishabh2609 commented Aug 14, 2017

AnshulMalik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rewanthtammana left a comment

Choose a reason for hiding this comment

rewanthtammana left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rewanthtammana left a comment

Choose a reason for hiding this comment

rewanthtammana Aug 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rewanthtammana left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rewanthtammana commented Aug 19, 2017

AnshulMalik commented Sep 8, 2017 • edited Loading

rewanthtammana Aug 14, 2017 •

edited

Loading

AnshulMalik commented Sep 8, 2017 •

edited

Loading