Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landing page updated #1

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added landing page/css/HelveticaBold.ttf
Binary file not shown.
Binary file added landing page/css/HelveticaNeue.ttf
Binary file not shown.
Binary file added landing page/css/X.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions landing page/css/bootstrap.min.css

Large diffs are not rendered by default.

55 changes: 55 additions & 0 deletions landing page/css/main.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
@font-face {
font-family: hLight;
Copy link
Member

@rewanthtammana rewanthtammana Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the default tab spaces to 2. The code looks clean from L58-76. Follow the same kind of indentation from line from lines 1 to 58.

Follow the same coding convention in all the files.

src: url(HelveticaNeue.ttf);
}
@font-face {
font-family: hBold;
src: url(HelveticaBold.ttf);
}
body, html {
width: 100%;
overflow-x: hidden;
margin: 0px;
padding: 0px;
color: #fff;
font-family: hLight;
text-align: center;
}
span {
transition: all 0.5s ease;
}
#splash {
background: #ff2b06;
width: 10px;
height: 10px;
transform: translate(50vw, 50vh);
transform-origin: 50% 50%;
border-radius: 100%;
}
.hidden {
display: none;
}
small {
color: #fff !important;
margin-left: 20px;
}
ul {
list-style-type: none;
}
li {
display: inline;
margin: 20px;
}
#main_info_cont, #coming_soon {
opacity: 0;
}
.jumbotron {
min-height: 100vh;
background: transparent;
}
.transformation {
opacity: 0;
}
h1 {
font-family: hBold;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every file must contain a newline character at the end, in short, an empty line at the end.

Binary file not shown.
288 changes: 288 additions & 0 deletions landing page/fonts/glyphicons-halflings-regular.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
40 changes: 40 additions & 0 deletions landing page/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<!DOCTYPE html>
<html>
<head>
<title>TedX Nit Kurukshetra</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing meta-tags. Tags like author, links, description, charset, etc are missing.
Check the source-code of techspardha.org for more information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the indentation in all your files.

<link rel="stylesheet" type="text/css" href="css/bootstrap.min.css">
<link rel="stylesheet" type="text/css" href="css/main.css">
</head>
<body>
<div id="splash">
</div>
<div class="container" id="full_container">
<div class="jumbotron text-center">
<h1 id="main_info_cont" style="margin-top: 150px;">TEDx<small>Nit Kurukshetra</small></h1>
<h1 id="coming_soon">
<span id="1">C</span>
<span id="2">O</span>
<span id="3">M</span>
<span id="4">I</span>
<span id="5">N</span>
<span id="6">G</span>
<span>&nbsp;</span>
<span id="7">S</span>
<span id="8">O</span>
<span id="9">O</span>
<span id="10">N</span>
</h1>
<ul style="margin-top: 50px;">
<li><a href=""><img src="png/twitter.png"></a></li>
<li><a href=""><img src="png/youtube.png"></a></li>
<li><a href=""><img src="png/facebook.png"></a></li>
<li><a href=""><img src="png/gmail.png"></a></li>
</ul>
<footer style="margin-top: 150px;"><h4>Cooked with love by <a href="http://www.gawds.in" target="_blank"><img src="logo.png" id="logo"/></a></h4></footer>
</div>
</div>
</body>
<script src="js/jquery.min.js"></script>
<script src="js/TweenMax.min.js"></script>
<script src="js/main.js"></script>
</html>
17 changes: 17 additions & 0 deletions landing page/js/TweenMax.min.js

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions landing page/js/bootstrap.min.js

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions landing page/js/jquery.min.js

Large diffs are not rendered by default.

74 changes: 74 additions & 0 deletions landing page/js/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use two spaces as a tab? Which text editor are you using ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sublime

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should enable translate_tabs_to_spaces here: https://www.sublimetext.com/docs/3/indentation.html

function splittext() {
TweenMax.to('#main_info_cont', 1,
{
opacity: 0,
delay: 2.5
}
)
;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of snippet is preferred );.

Replace Line 8 and 9 with );.

Do the same at L16, L42, L49.

TweenMax.to('#coming_soon', 0.5,
{
opacity: 1,
delay: 2.5
}
)
;
var i = -10;
var interval = setInterval(
function() {
i++;
var obj = '#' + i;
console.log(obj);
$(obj).addClass('transformation');
obj = '#' + (i - 1);
$(obj).removeClass('transformation');
if(i == 20){
clearInterval(interval);
start();
}
}
,250
);
}
function start() {
$('body').css('background', '#ff2b06');
$('#splash').addClass('hidden');
TweenMax.to('#coming_soon', 0.5,
{
opacity: 0
}
)
;
TweenMax.to('#main_info_cont', 1,
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow standard conventions all over your code. Use format similar to call at Line54.

opacity: 1,
onComplete: splittext
}
)
;
}

function full_splash() {
var splash = $('#splash');
TweenMax.to(splash, 0.5, {
height: '500vh',
width: '500vh',
x: '-500px',
y: '-800px',
onComplete: start
}
);
}

function splash_screen() {
var splash = $('#splash');
TweenMax.to(splash, 0.2, {
opacity: 0,
repeat: 5,
yoyo: true,
onComplete: full_splash
}
);
}
splash_screen();
Binary file added landing page/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added landing page/png/facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added landing page/png/gmail.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added landing page/png/twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added landing page/png/youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.