Fix websocket proto request handling #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ahcorde
approved these changes
Oct 11, 2024
8 tasks
|
yes gzweb is missing support for shapes like like cone and ellipsoid, which are added in newer versions of gz |
|
Made a PR there to add the support : gazebo-web/gzweb#62 |
|
Thanks for the PR in gzweb. I think the gzweb team is focusing on something else. The project is still used by different groups of people. The devs are just not working on adding new features at the moment. |
|
@Mergifyio backport gz-launch7 |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
|
https://github.com/Mergifyio backport gz-launch7 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Ian Chen <[email protected]> (cherry picked from commit c60538a)
8 tasks
arilow
pushed a commit
to arilow/gz-launch
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Ian Chen <[email protected]>
azeey
pushed a commit
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Ian Chen <[email protected]> (cherry picked from commit c60538a) Co-authored-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Depends on gazebosim/gz-msgs#470
Fixes #246
Summary
Added workaround to fix websocket proto message request. Duplicate message types should be removed in gazebosim/gz-msgs#470. In addition, nested messages also leads to duplicate messages so worked around it by leaving it out of the response.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.