Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit to invoke ign command in Windows #73

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 27, 2021

🦟 Bug fix

Fixes #70 .

Summary

The fix is described in #70 (comment) .

Before this PR, if you invoked ign on Windows in Command Prompt, Powershell or Git Bash nothing happened. After this PR, ign will properly execute.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Nov 27, 2021
@chapulina chapulina added the Windows Windows support label Nov 29, 2021
@chapulina chapulina merged commit af7fc85 into gazebosim:ign-tools1 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support invocation of ign command on Windows shells (Command Prompt, Powershell, Git Bash)
2 participants