-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bzlmod support #1499
Merged
Merged
bzlmod support #1499
+1,877
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sdf15 #1499 +/- ##
========================================
Coverage ? 92.47%
========================================
Files ? 138
Lines ? 18322
Branches ? 0
========================================
Hits ? 16943
Misses ? 1379
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mjcarroll
reviewed
Nov 7, 2024
Signed-off-by: Shameek Ganguly <[email protected]>
mjcarroll
approved these changes
Nov 11, 2024
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Bzlmod support
Original PR from @mjcarroll: #1493
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.