Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style by reverting HTML5 DOCTYPE #48

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Sep 19, 2024

image

@Rangi42
Copy link
Contributor Author

Rangi42 commented Sep 19, 2024

Wow, it's been decades since I've had to think about the rendering quirks that not having a DOCTYPE makes the browser do.

@SelvinPL
Copy link
Contributor

SelvinPL commented Sep 19, 2024

wait

.container {
    display: grid;
    grid-template-columns: 200px auto 520px;
    grid-template-rows: 21px auto 20%;
    grid-gap: 0;
    height: calc(100vh - 20px);;
}


.emulator_screen_container {
    width: 512px;
    height: 512px;
}
.emulator_canvas_screen {
    width: 480px;
}
.emulator_vram_screen {
    width: 512px;
}

@media only screen and (max-height: 600px) {
    .emulator_screen_container {
        width: 256px;
        height: 256px;
    }
    .emulator_canvas_screen {
        width: 240px;
    }
    .emulator_vram_screen {
        width: 256px;
    }
}

fixes this

there was no units and height: calc(100vh - 20px);

@Rangi42
Copy link
Contributor Author

Rangi42 commented Sep 19, 2024

Mind if we go with the simpler "revert the doctype I added for no particular reason" change? And then consider adding it back and making these deeper changes to how the layout works in non-quirks mode?

@SelvinPL
Copy link
Contributor

Sure

@Rangi42 Rangi42 merged commit baf5817 into gbdev:master Sep 19, 2024
1 check passed
@Rangi42 Rangi42 deleted the fix-page branch September 19, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants