fix global keyboard and window listeners are not removed after the map is destroyed

[plainheart]

Hi,

I noticed the global listeners bound in the keyboard mixin were not unbound after the map was destroyed, which makes the listener always exist and makes the code throw errors even if the component is destroyed in those single-page applications.

So I think we should unbind the listeners somewhere after destroying the map. I currently put this logic into the _initKeyListener function of the Keyboard mixin. Also, to keep the isolation of the mixin, I changed the singleton Keyboard mixin object to a function that returns a new object at each call to make it work for multiple map instances, or the entire listener will be removed as long as one map is destroyed, which causes the event listener for other maps to not work.

To reproduce,

• https://codepen.io/plainheart/pen/bGZVxgv
• Or just open demo/index.html in this project and call map.remove()

[Falke-Design]

Thank you, good catch!

I will approve this but are you able to add some tests?

And do you think we have with some other Mixins problems when there are multiple maps?

[plainheart]

@Falke-Design Just added a simple test case but I'm not sure if it's enough.

And do you think we have with some other Mixins problems when there are multiple maps?

It looks other mixins are not binding events on the global objects like window and document. There might be no obvious problem with them. One suggestion is to provide an API to allow users to unmount (or destroy/remove/dispose) the PM plugin and clean up the relative resources like listeners and mounted objects. - This may need a considerable amount of job.

[Falke-Design]

This test is enough for now. Please check out the comments

[Falke-Design]

Thank you for your contribution!