Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix global keyboard and window listeners are not removed after the map is destroyed #1434

Merged
merged 6 commits into from
Feb 4, 2024
Merged

fix global keyboard and window listeners are not removed after the map is destroyed #1434

merged 6 commits into from
Feb 4, 2024

Commits on Jan 2, 2024

  1. fix global keyboard and window listeners are not removed after the ma… 

    …p is destroyed
    @plainheart
    plainheart committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    7852bb0 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. test: add a test case for keyboard mixin

    @plainheart
    plainheart committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    f725b39 View commit details
    Browse the repository at this point in the history

  2. change map.on to map.once & extract keyboard event listener unbin… 

    …d function

Co-authored-by: Florian Bischof <[email protected]>
    @plainheart @Falke-Design
    plainheart and Falke-Design committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    7ac3dd5 View commit details
    Browse the repository at this point in the history

  3. fix missing dot operator

    @plainheart
    plainheart committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    c3c1c84 View commit details
    Browse the repository at this point in the history

  4. tweak the mixins test case 

    Co-authored-by: Florian Bischof <[email protected]>
    @plainheart @Falke-Design
    plainheart and Falke-Design committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    3134ab8 View commit details
    Browse the repository at this point in the history

  5. Fix test naming

    @Falke-Design
    Falke-Design committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    598e2f9 View commit details
    Browse the repository at this point in the history