Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visibility of column sort state adjust sliders #118

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

brianlove
Copy link
Contributor

Highlight the ascending/descending arrow to improve the visibility of the column's current sort state. Slightly reduce the size of the slider handles.

Closes #97, closes #98

@brianlove brianlove requested review from jmelot and za158 September 25, 2023 15:37
@brianlove brianlove self-assigned this Sep 25, 2023
@github-actions
Copy link

No need for rebasing 👍
behind_count is 0
ahead_count is 1

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 73%
73.07% (266/364) 61.33% (92/150) 77.04% (94/122)
Modified Files • (73%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files73.0761.3377.0473.56 
components74.565.1177.8974.91 
   HeaderSlider.jsx84.6110071.4284.6156–57
   ListViewTable.jsx89.0874.7593.3390.3158, 189–190, 195–202, 260, 293–294, 328, 343, 426–431, 462, 497

Highlight the ascending/descending arrow to improve the visibility of
the column's current sort state.  Slightly reduce the size of the
slider handles.

Closes #97, closes #98
@jmelot jmelot force-pushed the 97-98-list-view-column-header-adjustments branch from 7512506 to 00fe564 Compare September 26, 2023 15:07
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks nice!

@jmelot jmelot merged commit 7b1cd9b into version2 Sep 26, 2023
@jmelot jmelot deleted the 97-98-list-view-column-header-adjustments branch September 26, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants