Add partial year shading #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need for rebasing 👍 |
Base automatically changed from
gui-updates-following-data-updates
to
138-134-18-data-structure-updates
October 20, 2023 12:22
Base automatically changed from
138-134-18-data-structure-updates
to
version2
October 20, 2023 12:22
Simplify charts by combining two components that are only used with each other.
brianlove
force-pushed
the
142-add-partial-year-shading
branch
from
f4a9e12 to
3ea3423
Compare
Re-query for the dialog element instead of reusing the prior element as suggested in testing-library/dom-testing-library#1204 (comment)
JavaScript CoverageSummary
Modified Files • (66%)
|
jmelot
approved these changes
Oct 30, 2023
| type: "scatter", | ||
| } | ||
|
|
||
| // TODO / QUESTION: How do we want to handle the line/shading style for the |
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shading to graphs for years with partial data, and merges two related chart components
Closes #142, closes #78