Move default column array to the column definitions file #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update table column definitions to match the latest data Closes #92
Add column definitions for remaining requested columns, adding notes about what is still needed (where relevant)
Updated tests to reflect the new selection of initial columns. Commented out the group selector test since that interface will be changing substantially in #94 and was impacted by the UI Components update.
Update row filtering to account for growth columns, which can have negative values. Updated column generation to prevent columns with similar keys from interfering with each other.
|
No need for rebasing 👍 |
Re-query for the dialog element instead of reusing the prior element as suggested in testing-library/dom-testing-library#1204 (comment)
Resolve a lack of persistence of column slider filters by moving the default column array to the general column definitions file instead of in ListViewTable. If the persistence issues return, try just hardcoding `DEFAULT_COLUMNS` instead of building it using `initialCol`. Closes #144
brianlove
force-pushed
the
144-slider-filter-persistence
branch
from
75a4449 to
d0df51d
Compare
jmelot
force-pushed
the
92-adjust-available-columns
branch
from
a6d8b4a to
2b9372f
Compare
brianlove
force-pushed
the
92-adjust-available-columns
branch
3 times, most recently
from
993c151 to
5a863d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a lack of persistence of column slider filters by moving the default column array to the general column definitions file instead of in ListViewTable.
If the persistence issues return, try just hardcoding
DEFAULT_COLUMNSinstead of building it usinginitialCol.Closes #144
TODO: Re-target branch after #154 is merged