Add tooltips in jobs columns #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need for rebasing 👍 |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
JavaScript CoverageSummary
Modified Files • (67%)
|
brianlove
force-pushed
the
326-tooltips-for-jobs-numbers
branch
from
a531cc9 to
6bcead9
Compare
brianlove
changed the title
Add tooltips in the jobs columns providing explanatory information about limitations of the numbers. Update uses of HelpTooltip to use small icons where appropriate. Closes #326
jmelot
force-pushed
the
326-tooltips-for-jobs-numbers
branch
from
6bcead9 to
2b7107a
Compare
jmelot
approved these changes
May 31, 2024
| country = undefined, | ||
| data, | ||
| }) => { | ||
| const tooltipType = (country === "United States") ? undefined : ( |
There was a problem hiding this comment.
This is a little bit hard to read, might be easier as a series of if statements!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tooltips in the jobs columns providing explanatory information about limitations of the numbers.
Closes #326