Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips in jobs columns #362

Merged
merged 1 commit into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions web/gui-v2/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion web/gui-v2/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"dependencies": {
"@emotion/react": "^11.11.1",
"@eto/eto-ui-components": "^1.7.2",
"@eto/eto-ui-components": "^1.8.0",
"@mdx-js/react": "^2.3.0",
"@mui/icons-material": "^5.11.16",
"@mui/material": "^5.13.5",
Expand Down
2 changes: 1 addition & 1 deletion web/gui-v2/src/components/AddRemoveColumnDialog.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ const AddRemoveColumnDialog = ({
disabled={colDef.key === "name"}
/>
{colDef.title}
{colDef?.tooltip && <HelpTooltip text={colDef.tooltip} />}
{colDef?.tooltip && <HelpTooltip smallIcon={true} text={colDef.tooltip} />}
</label>
))
}
Expand Down
45 changes: 43 additions & 2 deletions web/gui-v2/src/components/CellStat.jsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import React from 'react';
import { css } from '@emotion/react';
import { Warning as WarningIcon } from '@mui/icons-material';

import { HelpTooltip } from '@eto/eto-ui-components';

import { tooltips } from '../static_data/tooltips';
import { commas } from '../util';

const styles = {
Expand All @@ -23,13 +27,50 @@ const styles = {
color: #a0a0a0;
}
`,
cellWithTooltip: css`
/* Add a column for the tooltip to fit in. Same note as above on 3.2em. */
grid-template-columns: auto 1fr 3.2em;
`,
};

const EMPTY_VALUES = [null, '---'];

const CellStat = ({data, colKey}) => {
const tooltipTypes = {
"United States": {},
"China": {
text: tooltips.jobsExplanations.chinaJobs,
Icon: WarningIcon,
iconCss: css`fill: var(--orange);`,
},
"noData": {
text: tooltips.jobsExplanations.noData,
iconCss: css`fill: var(--grey);`,
},
"other": {
text: tooltips.jobsExplanations.otherJobs,
Icon: WarningIcon,
iconCss: css`fill: var(--orange);`,
},
};

const CellStat = ({
col,
country = undefined,
data,
}) => {
const tooltipType = (country === "United States") ? undefined : (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little bit hard to read, might be easier as a series of if statements!

(country === "China") ? "China" : (
(data?.total === null || data?.total === undefined) ? "noData" : (
country ? "other" : undefined
)
)
);

return (
<div css={styles.cell}>
<div css={[styles.cell, tooltipType && styles.cellWithTooltip]}>
{tooltipType &&
<HelpTooltip smallIcon={true} {...tooltipTypes[tooltipType]} />
}
<div className="val">
{ data?.total === null ? 'n/a' : commas(data.total) }
</div>
Expand Down
3 changes: 2 additions & 1 deletion web/gui-v2/src/components/ListViewTable.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ const styles = {
}
`,
buttonBarRight: css`
display: flex;
margin-left: auto;
`,
buttonBarButton: css`
Expand Down Expand Up @@ -238,7 +239,7 @@ const GROUPS_OPTIONS = Object.entries(overallData.groups)
text: (
tooltips?.groupExplanations?.[k] ?
<div css={styles.dropdownEntryWithTooltip}>
{v.name} <HelpTooltip css={styles.groupExplanationTooltip} text={tooltips.groupExplanations[k]} />
{v.name} <HelpTooltip css={styles.groupExplanationTooltip} smallIcon={true} text={tooltips.groupExplanations[k]} />
</div>
:
v.name
Expand Down
15 changes: 5 additions & 10 deletions web/gui-v2/src/static_data/table_columns.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React from 'react';
import { css } from '@emotion/react';

import { tooltips } from './tooltips';
import overall from '../static_data/overall_data.json';
import CellStat from '../components/CellStat';
import { slugifyCompanyName } from '../util';
Expand Down Expand Up @@ -571,11 +572,8 @@ const columnDefinitions = [
"ai_jobs",
undefined, // Use default extract function
(_val, row) => {
if ( row?._group || row.linkedin.length > 0 ) {
return <CellStat data={row.other_metrics.ai_jobs} />;
} else {
return <CellStat data={{ total: null }} />
}
const data = (row?._group || row.linkedin.length > 0) ? row.other_metrics.ai_jobs : {total: null};
return <CellStat col="ai_jobs" country={row.country} data={data} />;
},
),
tooltip: "Zach_tktk"
Expand All @@ -589,11 +587,8 @@ const columnDefinitions = [
"tt1_jobs",
undefined, // Use default extract function
(_val, row) => {
if ( row?._group || row.linkedin.length > 0 ) {
return <CellStat data={row.other_metrics.tt1_jobs} />;
} else {
return <CellStat data={{ total: null }} />
}
const data = (row?._group || row.linkedin.length > 0) ? row.other_metrics.tt1_jobs : {total: null};
return <CellStat col="tt1_jobs" country={row.country} data={data} />;
},
),
initialCol: true,
Expand Down
5 changes: 5 additions & 0 deletions web/gui-v2/src/static_data/tooltips.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ const tooltips = {
</>
),
},
jobsExplanations: {
chinaJobs: "zach_tktk_china",
otherJobs: "zach_tktk_other",
noData: "--zach_tktk_null--",
},
};

export { tooltips };
Loading