Perform full sync of app on-chain wallet on startup if needed #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckysori
force-pushed
the
feat/full-sync-if-needed
branch
from
0789884
to
14b19a7
Compare
holzeis
approved these changes
Mar 5, 2024
luckysori
force-pushed
the
feat/full-sync-if-needed
branch
from
14b19a7
to
8ae28fe
Compare
So that it doesn't clash with the file name we used to use before the upgrade to `bdk:1.0.0`.
With the recent upgrade to `bdk:1.0.0`, we dropped existing wallet DBs in favour of a new format. This meant that a user would have to manually populate the new wallet DB to be able to see their wallet history and funds. This is not a very good user experience, as at least some users would be surprised by this. This is why we have decided to execute a full wallet sync on startup if we find an old wallet DB. Once complete, we delete the old wallet DB since the data is irrelevant and we do not want to run a full sync on startup every time.
- The padding was missing. - I found the full sync text a little bit unclear given the complexity of the task. I've made it a lot more verbose, which I think is okay since this screen is currently only being used for this.
luckysori
force-pushed
the
feat/full-sync-if-needed
branch
from
8ae28fe
to
8a692fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2130.
With the recent upgrade to
bdk:1.0.0, we dropped existing wallet DBs in favour of a new format. This meant that a user would have to manually populate the new wallet DB to be able to see their wallet history and funds.This is not a very good user experience, as at least some users would be surprised by this. This is why we have decided to execute a full wallet sync on startup if we find an old wallet DB. Once complete, we delete the old wallet DB since the data is irrelevant and we do not want to run a full sync on startup every time.
The message is now updated based on the state of the background task 🎉 (Thanks, @holzeis).