Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform full sync of app on-chain wallet on startup if needed #2151

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Perform full sync of app on-chain wallet on startup if needed #2151

merged 4 commits into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. chore(app): Rename BDK wallet DB file 

    So that it doesn't clash with the file name we used to use before the
upgrade to `bdk:1.0.0`.
    @luckysori
    luckysori committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    084343d View commit details
    Browse the repository at this point in the history

  2. feat(app): Perform full sync if old wallet DB is present 

    With the recent upgrade to `bdk:1.0.0`, we dropped existing wallet DBs
in favour of a new format. This meant that a user would have to
manually populate the new wallet DB to be able to see their wallet
history and funds.

This is not a very good user experience, as at least some users would
be surprised by this. This is why we have decided to execute a full
wallet sync on startup if we find an old wallet DB. Once complete, we
delete the old wallet DB since the data is irrelevant and we do not
want to run a full sync on startup every time.
    @luckysori
    luckysori committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2fece00 View commit details
    Browse the repository at this point in the history

  3. chore: Fix ambiguous pub use statement

    @luckysori
    luckysori committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7b150a5 View commit details
    Browse the repository at this point in the history

  4. chore(app): Tweak wallet settings page 

    - The padding was missing.
- I found the full sync text a little bit unclear given the complexity
  of the task. I've made it a lot more verbose, which I think is okay
  since this screen is currently only being used for this.
    @luckysori
    luckysori committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    8a692fc View commit details
    Browse the repository at this point in the history