Upgrade to Rails 6.1 #203
Draft
Upgrade to Rails 6.1 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we get a lot of the value of security updates by going to |
|
This should be targeted against |
We don't use it, and having it enabled makes upgrading Rails harder.
`update_attributes` will be removed in Rails 6.1. This deprecation
warning was being printed:
update_attributes is deprecated and will be removed from Rails 6.1
(please, use update instead)
The command that generated these changes was
bundle update --conservative actioncable actionmailbox \
actionmailer actionpack actiontext actionview \
activesupport activemodel activerecord activestorage \
rails railties tzinfo
patbl
force-pushed
the
upgrade-to-rails-6.1
branch
from
7a15043
to
2881105
Compare
quinn-dougherty
temporarily deployed
to
guesstimate-upgrade-to--orirap
|
I changed the base branch, resolved the merge conflicts, and moved some non-essential commits to a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the app to 6.1.6.1, the latest released version of Rails as of this writing. According to this page, Rails 6.0.x (the version the app is currently running on) receives updates for "severe security issues" but not for "security issues." Rails 6.1.x receives updates for both "severe security issues" and "security issues." Only 7.0 is guaranteed to receive bug fixes, though I think bug fixes aren't especially important for this app.
Test plan